tdse-tp3_02-code_integration

Index Commits Files Refs

commit acda5b3c8ec2ab299e4b72784e3a9632d9e5b4ed
parent 6bc6eae6f994cba9682f5eac33d4f6b25883ddd9
Author: Martin Kloeckner <mjkloeckner@gmail.com>
Date:   Wed,  8 Oct 2025 14:47:51 -0300

Remove non-necessary `display_initialized` flag

Diffstat:
M
app/src/display.c
 | 
26
++++++--------------------
M
app/src/task_test.c
 | 
1
-

2 files changed, 6 insertions(+), 21 deletions(-)
diff --git a/app/src/display.c b/app/src/display.c
@@ -69,9 +69,6 @@
 #define DISPLAY_DEL_37US 37ul
 #define DISPLAY_DEL_01US 01ul
 
-// private global vars
-static bool display_initialized;
-
 // declaration of private functions
 static void display_pin_write(uint8_t pin_name, int value);
 static void display_data_bus_write(uint8_t data_byte);
@@ -81,8 +78,6 @@ static void display_code_write(bool type, uint8_t data_bus);
 
 void display_init(void)
 {
-    display_initialized = false;
-
     display_code_write(DISPLAY_RS_INSTRUCTION,
             DISPLAY_IR_FUNCTION_SET |
             DISPLAY_IR_FUNCTION_SET_4BITS |
@@ -90,12 +85,6 @@ void display_init(void)
             DISPLAY_IR_FUNCTION_SET_5x8DOTS);
 
     display_code_write(DISPLAY_RS_INSTRUCTION,
-            DISPLAY_IR_DISPLAY_CONTROL |
-            DISPLAY_IR_DISPLAY_CONTROL_DISPLAY_OFF |
-            DISPLAY_IR_DISPLAY_CONTROL_CURSOR_ON |
-            DISPLAY_IR_DISPLAY_CONTROL_BLINK_ON);
-
-    display_code_write(DISPLAY_RS_INSTRUCTION,
             DISPLAY_IR_CLEAR_DISPLAY);
 
     display_code_write(DISPLAY_RS_INSTRUCTION,
@@ -109,7 +98,6 @@ void display_init(void)
             DISPLAY_IR_DISPLAY_CONTROL_CURSOR_ON |
             DISPLAY_IR_DISPLAY_CONTROL_BLINK_ON);
 
-    display_initialized = true;
 }
 
 void display_char_position_write(uint8_t x, uint8_t y)
@@ -216,14 +204,12 @@ static void display_data_bus_write( uint8_t data_bus )
     display_pin_write( DISPLAY_PIN_D5, data_bus & 0b00100000 );
     display_pin_write( DISPLAY_PIN_D4, data_bus & 0b00010000 );
 
-    if ( display_initialized  == true) {
-        display_pin_write( DISPLAY_PIN_EN, ON );
-        display_pin_write( DISPLAY_PIN_EN, OFF );
-        display_pin_write( DISPLAY_PIN_D7, data_bus & 0b00001000 );
-        display_pin_write( DISPLAY_PIN_D6, data_bus & 0b00000100 );
-        display_pin_write( DISPLAY_PIN_D5, data_bus & 0b00000010 );
-        display_pin_write( DISPLAY_PIN_D4, data_bus & 0b00000001 );
-    }
+    display_pin_write( DISPLAY_PIN_EN, ON );
+    display_pin_write( DISPLAY_PIN_EN, OFF );
+    display_pin_write( DISPLAY_PIN_D7, data_bus & 0b00001000 );
+    display_pin_write( DISPLAY_PIN_D6, data_bus & 0b00000100 );
+    display_pin_write( DISPLAY_PIN_D5, data_bus & 0b00000010 );
+    display_pin_write( DISPLAY_PIN_D4, data_bus & 0b00000001 );
 
     display_pin_write( DISPLAY_PIN_EN, ON );
     display_pin_write( DISPLAY_PIN_EN, OFF );
diff --git a/app/src/task_test.c b/app/src/task_test.c
@@ -97,7 +97,6 @@ void task_test_init(void *parameters)
 
     /* Init & Print out: LCD Display */
     display_init();
-    display_cursor_off();
 
     display_char_position_write(0, 0);
     display_string_write("Hello, World!");