st

fork of suckless's simple terminal
Index Commits Files Refs README LICENSE
commit d7bf023b2f2d41cb6983bb3ce2c6d1bf049150b3
parent b4d68d4daa2716c0064605a2a92082a7287ee54a
Author: Hiltjo Posthuma <hiltjo@codemadness.org>
Date:   Sun,  4 Nov 2018 14:35:07 +0100

fix memory leak in xloadcols()

reported by Avi Halachmi (:avih)" <avihpit@yahoo.com>

patch slightly changed by me.

Diffstat:
Mx.c | 6+++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/x.c b/x.c
@@ -733,12 +733,12 @@ xloadcols(void)
     static int loaded;
     Color *cp;
 
-    dc.collen = MAX(LEN(colorname), 256);
-    dc.col = xmalloc(dc.collen * sizeof(Color));
-
     if (loaded) {
         for (cp = dc.col; cp < &dc.col[dc.collen]; ++cp)
             XftColorFree(xw.dpy, xw.vis, xw.cmap, cp);
+    } else {
+        dc.collen = MAX(LEN(colorname), 256);
+        dc.col = xmalloc(dc.collen * sizeof(Color));
     }
 
     for (i = 0; i < dc.collen; i++)